Skip to content

Fixes #16101: Fix initial loading of pagination widget for dynamic object tables #16118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #16101

Refactor HTMX table structure to swap the entire container, ensuring that the paginator is always included where appropriate.

Please test thoroughly. It seems to work fine AFAICT but there may be some corner cases lingering that I have not considered.

@jeremystretch jeremystretch requested a review from arthanson May 13, 2024 20:02
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working, completely separate issue it looks like site list isn't paginated

@jeremystretch jeremystretch merged commit c7850b5 into develop May 13, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 16101-fix-table-pagination branch May 13, 2024 22:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

htmx_table is missing pagination
2 participants