Fix #8956: Save old JobResults #8957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkthxbye-code
force-pushed
the
save-job-results
branch
2 times, most recently
from
8f25c05 to
e459805
Compare
|
Is it enough to just change the base branch on the PR via. the github ui? |
Yep that should work. |
|
Should be good to go now then I guess. |
and cleanup functionality to the housekeeping script
jeremystretch
force-pushed
the
save-job-results
branch
from
a35cad8 to
c216405
Compare
|
Thanks for all your work on this @kkthxbye-code! |
wmfgerrit
pushed a commit
to wikimedia/operations-software-netbox-extras
that referenced
this pull request
Jun 23, 2022
This CR updates the job so that it first deletes all previous versions of this report before running. The code is based on the PR that added the JOBRESULT_RETENTION config item[1] [1]netbox-community/netbox#8957 Bug: T311048 Change-Id: I8895a851592036fe34d1b24e42953510cbc754e6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8956
Removes all logic that deletes old JobResults. Also tweaks the view querysets to only return the newest terminal result.
Lastly removes unused JobResults in the homepage view, which seems like a leftover from the v2 -> v3 split.