Skip to content

max_branches should not count archived branches #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremystretch opened this issue Sep 13, 2024 · 0 comments · Fixed by #126
Closed

max_branches should not count archived branches #120

jeremystretch opened this issue Sep 13, 2024 · 0 comments · Fixed by #126
Assignees
@jeremystretch
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Contributor

jeremystretch commented Sep 13, 2024 •
edited
Loading

Plugin Version

v0.5.0

NetBox Version

v4.1.1

Python Version

3.10

Steps to Reproduce

  1. Create & archive three branches
  2. Set max_branches to 1
  3. Attempt to create a new branch

Expected Behavior

The max_branches config parameter currently applies to the total count of all branches.

Observed Behavior

Archived branches should be excluded from the total count.
@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Sep 13, 2024
@jeremystretch jeremystretch self-assigned this Sep 13, 2024
jeremystretch added a commit that referenced this issue Sep 16, 2024
@jeremystretch
Fixes #120: max_branches should disregard archived branches
501bcab
@jeremystretch jeremystretch mentioned this issue Sep 16, 2024
Merged
jeremystretch added a commit that referenced this issue Sep 16, 2024
@jeremystretch
Fixes #120: max_branches should disregard archived branches
57bbee6
@jeremystretch jeremystretch mentioned this issue Sep 25, 2024
Merged
jeremystretch added a commit that referenced this issue Sep 25, 2024
@jeremystretch
Fixes #120: max_branches should disregard archived branches
548d604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #120: max_branches should disregard archived branches netboxlabs/netbox-branching
1 participant
@jeremystretch