This repository was archived by the owner on Oct 19, 2022. It is now read-only.
Merge changes from upstream #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
It doesn't look like there is any backwards incompatibility: https://github.com/webpack/webpack-dev-server/releases
* Add link to active CSS modules discussion * Update README.md
* File headers BSD+Patents -> MIT * BSD+Patents -> MIT
Also, clarify hot reloading a bit.
Correct manual proxy documentation
Changed `<!doctype html>` to `<!DOCTYPE html>` According to the spec it should be uppercase (but parsing is case insensitive)
* Allow the dev server to watch for changes in src/node_modules * fix eslint error * fix broken regex * handle trailing slash edge case for file paths Closes facebook#2760 Fixes facebook#3223
* Windows compatibility * Use regex for mutli-replace
* Make error overlay to run in the context of the iframe * Configure webpack to build the entire package * Remove inline raw-loader config * Configure watch mode for error-overlay webpack build * Add polyfills to the error-overlay iframe script * Add header comment * Configure to fail CI on error or warning * Suppress flow-type error on importing iframe-bundle * Change webpack to a dev dependency and pin some versions * Disable webpack cache * Update license headers to MIT
* Implement click-to-open for babel syntax errors in build error overlay * Add click-to-open support for lint errors and refactor parser * Reactor code to reuse open-in-editor functionality in both build and runtime error overlays * Fix some eslint warnings * Add a comment about keeping middleware and dev client in sync * Remove es6 features from webpack dev client * Make open-in-editor functionality to work with new iframe script * Rename `openInEditor` to `editorHandler` - Remove indirection of openInEditorListener - Check editorHandler for null before styling error clickable * Fix flow errors
* `react-error-overlay` has no dependencies now (it's bundled) * Use babel 6 for now
…3264) * Add a warning when running minified * Add more robust check * Update index.js
* Use production React version * We cannot strip our own checks if production * Keep the sourcemap during minify * Prevent devtools pollution * Add some comments * sigh
The existing link lands on a 'this page has moved' placeholder that doesn't redirect to the correct location. This PR replaces it with the currently working URL.
* update eslint-plugin-react to 7.3.0 * Updated eslint-plugin-react to 7.4.0
Fixed a small grammatical issue that I noticed while browsing the README today
* Add link to VS Code troubleshooting guide * Update README.md
"subway" by itself is not a proper noun
* extra watch options regex to react-dev-utils * fix regex * add test * fix eslint error * include react-dev-utils test in CI script * attempt to fix import error * attempt to fix error on CI * Update .eslintrc
* one-line waiting for app start * remove fixed todo
* improve eject message * cross os implementation
* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag
* docs: adding section about debugging tests * docs: removing node-inspector references * docs: replacing terminal command with npm script * Update README.md
Fix another dead link
This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/a14617528cda23c6c88902ace1d083e4e13ac271/CHANGELOG.md))
the code got updated from `detect()` to `choosePort` while the comment did not.
Replaced `it's` with `its`
The launch configuration code provided is not compatible with VSCode since version 1.19. The proposed documentation change is based on the response by a VSCode team member. References: facebook#3602 (comment) microsoft/vscode#40293 (comment)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from upstream.
Some interesting commits:
manifest.jsonrequestAnimationFramepolyfill (necessary for Jest to work post-React 16) is now includedreact-router