Skip to content

Add utils.status.show() #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020
Merged

Add utils.status.show() #1264

merged 1 commit into from
May 13, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 13, 2020

This ads utils.status.show() as described in #1223.

This method let plugin authors surface information to the UI deploy summary.

Only one status is allowed by plugin. Calling the method twice discards the first call.

This PR only implements this feature partially. PRs for argument validation, error statuses, calling the API endpoint for statuses and printing the statuses on the terminal will follow up. It is hard to add tests until then, so I will need to add them once all those PRs are done.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 13, 2020
@ehmicky ehmicky requested a review from erezrokah May 13, 2020 11:09
@ehmicky ehmicky self-assigned this May 13, 2020
@ehmicky ehmicky merged commit c888652 into master May 13, 2020
@ehmicky ehmicky deleted the feat/status-utils branch May 13, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants