Validate arguments of utils.status.show()
#1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
erezrokah
approved these changes
May 13, 2020
ehmicky
force-pushed
the
feat/validate-status
branch
from
2537625 to
65b72a3
Compare
|
Fixed! I just added some tests to cover this PR. |
erezrokah
approved these changes
May 13, 2020
ehmicky
force-pushed
the
feat/validate-status
branch
from
65b72a3 to
1e143ca
Compare
|
I just simplified the tests so they all re-use the same fixture instead of having one fixture per test. |
erezrokah
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds input validation to the
utils.status.show()method (related to #1223).