Add error statuses #1271
Merged
Add error statuses #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
erezrokah
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1223.
This creates statuses for every plugin that errors. Those statuses are meant to be shown in the UI deploy summary.
The statuses are created using the same logic as the one used to print errors in build logs, with few differences to make them fit better in the UI deploy summary context.
Note that this PR does not have tests yet: in a follow-up PR, I will add the
statusesAPI call, which will make testing this PR much easier. I will add some tests then. The currently existing tests are passing though, so this should not break anything in the meantime.