Skip to content

Send statuses to the API #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

Send statuses to the API #1277

merged 1 commit into from
May 18, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 14, 2020

Part of #1223
Fixes #1238.

This sends success and error statuses to the Bitballoon API endpoint.

This PR also adds many tests:

  • API reporting under several conditions
  • fix the previous tests about "implicit" statuses, as previously discussed with @erezrokah
  • API reporting on different types of plugin errors
  • "implicit" status not used when a plugin did not complete due to another plugin making the build fail
  • the previous tests that were relying on checking the build logs are now also checking the API request
  • in CI builds, statuses should be sent to the API but not printed in logs

API testing works by mocking the HTTP request and snapshotting its request body, headers and method. The body is normalized so the snapshot remains stable over time and across machines.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 14, 2020
@ehmicky ehmicky requested a review from erezrokah May 14, 2020 18:21
@ehmicky ehmicky self-assigned this May 14, 2020
@ehmicky ehmicky force-pushed the feat/send-statuses-api branch from 0711714 to 5b69fd4 Compare May 14, 2020 18:23
@ehmicky ehmicky force-pushed the feat/send-statuses-api branch from 5b69fd4 to 82e2378 Compare May 16, 2020 13:33
@ehmicky ehmicky merged commit 15bfcc0 into master May 18, 2020
@ehmicky ehmicky deleted the feat/send-statuses-api branch May 18, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report plugin status at the end of builds
2 participants