fix: fixes an issue where the cache could not save .dot directories #4843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
lukasholzer
force-pushed
the
fix/workflow-1017
branch
from
3fb100d to
40c2420
Compare
lukasholzer
force-pushed
the
fix/workflow-1017
branch
from
40c2420 to
a0f7789
Compare
danez
reviewed
Feb 1, 2023
| await new Fixture('./fixtures/cache_utils').runWithBuild() | ||
| // should have cached files in the output message | ||
| const output = await new Fixture('./fixtures/cache_utils').runWithBuild() | ||
| t.snapshot(normalizeOutput(output)) |
There was a problem hiding this comment.
I like the comment, but wouldn't it be better to do some explicit matching here so we do not even need the comment?
Something like
t.true(output.includes("content inside dist/.dot\nhello.txt"))There was a problem hiding this comment.
That's a good point I hate those snapshots anyway 😂
danez
approved these changes
Feb 1, 2023
jobala
approved these changes
Feb 1, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pillar-workflow/issues/1017
Fixes #4254
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)