Skip to content

fix: update cpy and fix type errors #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tinfoil-knight
Copy link
Contributor

@tinfoil-knight tinfoil-knight commented Feb 18, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Partial fix for netlify/cli#4921, netlify/cli#2744.

This PR reduces the amount of security vulnerabilities reported by npm audit so that netlify-cli (dependent on packages in this repo) shows lesser warnings on installation.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@tinfoil-knight
Copy link
Contributor Author

tinfoil-knight commented Feb 19, 2023

@danez Please review. (I don't have permissions to add reviewers on run workflows in this repository unfortunately)

@tinfoil-knight
Copy link
Contributor Author

tinfoil-knight commented Feb 19, 2023

PR opened by renovate is failing all tests due to the type errors.

#4199

Update:
Marking as draft due to the test errors.

Update:
There might be an error in how cpy is handling paths when passed the cwd (current working directory) option. I'm inspecting this & will push a fix in https://github.com/sindresorhus/cpy if necessary.

Update:
Created an issue here: sindresorhus/cpy#107

@danez danez requested review from lukasholzer, jobala and a team February 19, 2023 07:49
@tinfoil-knight tinfoil-knight marked this pull request as draft February 19, 2023 11:59
@github-actions github-actions bot added the stale label Apr 21, 2023
@github-actions github-actions bot removed the stale label May 11, 2023
@danez
Copy link
Contributor

danez commented May 16, 2023

Already done in #5011

@danez danez closed this May 16, 2023
@tinfoil-knight tinfoil-knight deleted the security-cpy branch June 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants