-
Notifications
You must be signed in to change notification settings - Fork 400
feat: add kebab-case options to cli flags #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kebab-case options to cli flags #5395
Conversation
📊 Benchmark resultsComparing with 87adddc Package size: 267 MB(no change)
|
c59a8c0
to
ac0c729
Compare
ac0c729
to
c7fae0c
Compare
@eduardoboucas mentioned that it might be worth not deprecating the old options and just keeping them but hidden. This way we don't have to add all the deprecation logic and it should not be a big maintenance overhead. Planning to reduce the scope of the issue to not include warnings about deprecating older options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Nice! Left a couple of minor comments, but this is looking great.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/team-dev/issues/55
This is an example of the way we could work on implementing new kebab-case options as CLI flags, as described in the above ticket.
In this example you can see how we could achieve the following:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)