fix: actually populate auth user field
#7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were reading from the wrong property.
ndhoule
requested changes
Apr 9, 2025
ndhoule
reviewed
Apr 15, 2025
src/utils/gh-auth.ts
Outdated
|
|
||
| const { authMethod } = await inquirer.prompt([ | ||
| const { authMethod } = (await inquirer.prompt([ |
There was a problem hiding this comment.
Didn't notice this before, but prompt accepts a generic:
Suggested change
| const { authMethod } = (await inquirer.prompt([ | |
| const { authMethod } = (await inquirer.prompt<{ authMethod: typeof authChoices[number] }>([ |
I don't think this is any more safe, but at least lets you avoid the assertion? 🤷
There was a problem hiding this comment.
Weird, I believe I'd tried that and couldn't get it working, but it's working fine now. I've just refactored all the inquirer.prompt type assertions. 👍🏼
ndhoule
reviewed
Apr 15, 2025
src/utils/gh-auth.ts
Outdated
| @@ -32,7 +32,7 @@ const promptForAuthMethod = async () => { | |||
| 'What would you like to do?', | |||
| choices: authChoices, | |||
| }, | |||
| ]) | |||
| ])) as { authMethod: typeof authChoices[number] } | |||
There was a problem hiding this comment.
Suggested change
| ])) as { authMethod: typeof authChoices[number] } | |
| ])) |
ndhoule
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The types fixes in #7130 identified a number of bugs. This fixes one of those. We were reading from the wrong property on the GitHub API response.