fix: mark siteInfo.published_deploy as optional
#7185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhoule
requested changes
Apr 9, 2025
|
@serhalp Ping me once CI is running again and you've resolved conflicts and I'll have a look. |
serhalp
force-pushed
the
refactor/fix-requiredness-of-published-deploy
branch
from
ce68940 to
a1c3fbd
Compare
ndhoule
approved these changes
Apr 15, 2025
serhalp
force-pushed
the
refactor/fix-requiredness-of-published-deploy
branch
from
347c5ce to
3e1134c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The types fixes in #7130 identified a number of issues. This fixes a couple of issues.
siteInfo.published_deployas optionalsiteInfo