This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Gatsby logo to returned framework info #797
feat: add Gatsby logo to returned framework info #797
Changes from 4 commits
7404bda
fb50fde
442df5f
d4d4a87
0366d1b
961a27d
e8be79a
a9bab1e
20f8e7c
8edd4c5
1ae4b7a
9abb30a
41b0488
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why
logo
is being added here only for Sapper when the PR is adding only Gatsby logos at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's being added here because with the overall set of changes
logo
is being returned for all frameworks as part of the response body.This particular snapshot is for a different test, and uses sapper instead of Gatsby, which is why this is appearing