-
Notifications
You must be signed in to change notification settings - Fork 237
Firefox and Chrome not picking up password field (for auto-filling) #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
1Password doesn't detect the fields for auto-filling either. I think it's related to this issue. Tested in Chrome and Brave with 1Password extension. |
no idea whats the cause. open to ideas |
I did some research here, what I found said password managers look for a The same goes for the password field. However... I tried this out by directly editing the html so that it conformed to the recommendations, and things still didn't work. Maybe because the html needs to be like that when the page first loads? No idea. In any case, I posted a question on the 1Password forum, will see if anyone responds. |
A 1Password team member responded:
|
Should we try adding https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete |
I've been able to get Chrome to save the password credentials, but not autocomplete on a repeat visit. Demo: https://wonderful-bell-ea255a.netlify.com/ Probably still a problem with using |
The issue is due to about:blank. Password managers save passwords according to the URL/origin of the document containing the login fields (about:blank in this case) but saving/filling for about:blank wouldn't make sense and would introduce security issues. Based on #17, I think the iframe was used for encapsulation so maybe Shadow DOM is a viable alternative option now? |
This problem still exists from what I can tell:
My #275 will only help when this bug is also fixed. |
thanks @mnoorenberghe — we'll dig into this |
FYI, Bitwarden is not able to fill out the credentials. I would assume it's the same behaviors for other password managers. |
Fix netlify#161 The problem: the widget uses an iframe to encapsulate its CSS and prevent leaking it to the projects using the widget (and vice versa). But since the iframe has a `src` attribute with the value `about:blank`, password managers do not work properly (they refuse to set a password without a corresponding url). The solution: as suggested by this comment netlify#161 (comment), this commit replaces the iframe by a shadow DOM element, which still encapsulates the modal CSS, but lets password managers do their thing (confirmed on Firefox 84.0.2).
Hi all, I've made a pull request to use Shadow DOM instead of an iframe if anyone wants to take a look. |
@kimlai I'm not a github expert but I think you need to add a label to the pull request, and then it'll pass all the checks and maybe someone will be able to review it. |
Hi @renschler, I don't think that's it because I don't can't add labels on pull requests in this repository. |
oh @kimlai gotcha. @jlengstorf could @kimlai's PR be merged in? I get a decent amount of support requests (~1hr / week) related to this. |
I've recently run into this issue as well. What can we do to bump this along? New discussion from this last week: https://1password.community/discussion/comment/602215#Comment_602215 |
Any updates here? Running into this issue myself. |
Ran into this issue on a client website and would love to see this resolved |
Also still seem to have this issue. This is very un-userfriendly especially on mobile. |
A nudge for this, as I believe it should be basic behaviour nowadays (2022). Thanks. |
@jlengstorf Looks like there has been a fix for this available (#416) going on 2 years. Can you look into this or ask someone to look into this? |
Another nudge to get some eyes on this and #416 |
Any updates on this? |
@wiredacorn damn you teased with this alert, I thought it was an update 😄 |
Tested on Firefox 64.0 and Google Chrome 70.0.3538.102 on Linux.
The text was updated successfully, but these errors were encountered: