Skip to content

Firefox and Chrome not picking up password field (for auto-filling) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasbah opened this issue Nov 23, 2018 · 23 comments · May be fixed by #416
Open

Firefox and Chrome not picking up password field (for auto-filling) #161

kasbah opened this issue Nov 23, 2018 · 23 comments · May be fixed by #416
Labels
good first issue help wanted type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@kasbah
Copy link

kasbah commented Nov 23, 2018

Tested on Firefox 64.0 and Google Chrome 70.0.3538.102 on Linux.

@renschler
Copy link

renschler commented Jan 16, 2019

1Password doesn't detect the fields for auto-filling either. I think it's related to this issue. Tested in Chrome and Brave with 1Password extension.

@swyxio
Copy link
Contributor

swyxio commented Jan 16, 2019

no idea whats the cause. open to ideas

@renschler
Copy link

renschler commented Jan 26, 2019

I did some research here, what I found said password managers look for a <label for="email"> element above the <input> (ie a sibling element, today I see the input is a child of the label). I also saw that the id of the input should be set to "email".

kenkeiter/skeuocard#42

The same goes for the password field.

However... I tried this out by directly editing the html so that it conformed to the recommendations, and things still didn't work. Maybe because the html needs to be like that when the page first loads? No idea.

In any case, I posted a question on the 1Password forum, will see if anyone responds.

@renschler
Copy link

A 1Password team member responded:

I don't know for certain but I suspect the issue is the iframe used for the widget has the source set as src="about:blank" and the extension requires a proper URL. I'm not sure how to easily test that theory though given the point of an iframe is to load an external page.

@Jinksi
Copy link

Jinksi commented Mar 1, 2019

Should we try adding autocomplete attributes?

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

@Jinksi
Copy link

Jinksi commented Mar 1, 2019

I've been able to get Chrome to save the password credentials, but not autocomplete on a repeat visit.

Demo: https://wonderful-bell-ea255a.netlify.com/
Branch: master...Jinksi:autocomplete

Probably still a problem with using src="about:blank" as @renschler mentioned

@mnoorenberghe
Copy link
Contributor

The issue is due to about:blank. Password managers save passwords according to the URL/origin of the document containing the login fields (about:blank in this case) but saving/filling for about:blank wouldn't make sense and would introduce security issues.

Based on #17, I think the iframe was used for encapsulation so maybe Shadow DOM is a viable alternative option now?

@mnoorenberghe
Copy link
Contributor

This problem still exists from what I can tell:

iframe.src = "about:blank";

My #275 will only help when this bug is also fixed.

@jlengstorf jlengstorf reopened this Jul 30, 2020
@jlengstorf
Copy link
Contributor

thanks @mnoorenberghe — we'll dig into this

@jlengstorf jlengstorf added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 30, 2020
@siamkreative
Copy link

FYI, Bitwarden is not able to fill out the credentials. I would assume it's the same behaviors for other password managers.

kimlai added a commit to kimlai/netlify-identity-widget that referenced this issue Jan 17, 2021
Fix netlify#161

The problem: the widget uses an iframe to encapsulate its CSS and
prevent leaking it to the projects using the widget (and vice versa).
But since the iframe has a `src` attribute with the value `about:blank`,
password managers do not work properly (they refuse to set a password
without a corresponding url).

The solution: as suggested by this comment netlify#161 (comment),
this commit replaces the iframe by a shadow DOM element, which still
encapsulates the modal CSS, but lets password managers do their thing
(confirmed on Firefox 84.0.2).
@kimlai kimlai linked a pull request Jan 17, 2021 that will close this issue
@kimlai
Copy link

kimlai commented Jan 24, 2021

Hi all,

I've made a pull request to use Shadow DOM instead of an iframe if anyone wants to take a look.

@renschler
Copy link

@kimlai I'm not a github expert but I think you need to add a label to the pull request, and then it'll pass all the checks and maybe someone will be able to review it.

@kimlai
Copy link

kimlai commented Jun 4, 2021

Hi @renschler, I don't think that's it because I don't can't add labels on pull requests in this repository.

@renschler
Copy link

oh @kimlai gotcha.

@jlengstorf could @kimlai's PR be merged in? I get a decent amount of support requests (~1hr / week) related to this.

@scouten
Copy link

scouten commented Jun 17, 2021

I've recently run into this issue as well. What can we do to bump this along? New discussion from this last week:

https://1password.community/discussion/comment/602215#Comment_602215

@galencorey
Copy link

Any updates here? Running into this issue myself.

@stuible
Copy link

stuible commented Dec 15, 2021

Ran into this issue on a client website and would love to see this resolved

@bvdekeer
Copy link

Also still seem to have this issue. This is very un-userfriendly especially on mobile.

@mashdot
Copy link

mashdot commented Oct 30, 2022

A nudge for this, as I believe it should be basic behaviour nowadays (2022). Thanks.

@HeyITGuyFixIt
Copy link

@jlengstorf Looks like there has been a fix for this available (#416) going on 2 years. Can you look into this or ask someone to look into this?

@mashdot
Copy link

mashdot commented Mar 5, 2023

Another nudge to get some eyes on this and #416

@wiredacorn
Copy link

Any updates on this?

@mashdot
Copy link

mashdot commented Apr 8, 2023

@wiredacorn damn you teased with this alert, I thought it was an update 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.