Skip to content

Allow display of SAML provider button #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

mraerino
Copy link
Contributor

@mraerino mraerino commented Aug 22, 2018

I am currently hired by Netlify to develop SAML 2.0 support in GoTrue. See this PR for the backend implementation: netlify/gotrue#181

There is going to be a external.saml key in the GoTrue /settings route.
This PR is used to add support for redirecting to this provider.

The SAML provider will behave exactly like any other provider in terms of frontend code. A redirect is issued to /authorize?provider=saml and the site receives a redirect with either a token or an error.

Also, this PR adds support to override the name of the provider which is used in the button of the widget. GoTrue will add a new key external_labels which contains these overrides. For the time being overrides will only be available for the SAML provider.

Example of the updated /settings payload:

{
    "external": {
        "bitbucket": false,
        "github": false,
        "gitlab": false,
        "google": false,
        "facebook": false,
        "email": false,
        "saml": true
    },
    "external_labels": {
        "saml": "G Suite"
    },
    "disable_signup": false,
    "autoconfirm": false
}

@bcomnes
Copy link
Contributor

bcomnes commented Aug 22, 2018

Adding this to the current sprint

Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcomnes bcomnes merged commit e86aec8 into netlify:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants