feat: add multilingual support #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Success! Built with commit 2d8acda |
marierigal
force-pushed
the
feat/multilang
branch
3 times, most recently
from
79938ac to
27645b7
Compare
erezrokah
added
the
type: feature
erezrokah
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Thanks @marierigal and sorry for taking so long to review this.
I rebased the branch, added some tests, updated the readme to include the optional locale in the init method. added a missing translation key (continue_with) under providers and an example usage to the demo site.
Also, any missing key should first default to the English locale, then to the key.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
en | frLinked to #128