Skip to content

feat: Add the ability to clear an invalid site URL #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

amorriscode
Copy link
Contributor

This PR adds the ability to clear an invalid site URL.

While I was going through the RedwoodJS authentication tutorial I had accidentally entered the wrong Netlify URL. It took me a hot minute to realize I had to remove it from my local storage. I figured it would be nice to have the "Clear localhost URL" button available if this error occurs.

Here's a gif of it in action!

NetlifyDX

@netlify
Copy link

netlify bot commented Jul 11, 2020

Deploy Success!

Built with commit a8a3afe

https://deploy-preview-305--identity.netlify.app

@netlify
Copy link

netlify bot commented Jul 11, 2020

Deploy Success!

Built with commit af973c6

https://deploy-preview-305--identity.netlify.app

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 12, 2020
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! I have one question that isn't a huge deal, but I wanted to check on it before we merge in case I'm missing something here

thanks for this!

@amorriscode amorriscode force-pushed the clear-invalid-site-url branch from 67e4dc1 to af973c6 Compare July 29, 2020 21:16
@amorriscode
Copy link
Contributor Author

@jlengstorf I rebased to get the latest and greatest and resolve lint errors! 🌮

@jlengstorf jlengstorf merged commit 3a97c42 into netlify:master Jul 29, 2020
@jlengstorf
Copy link
Contributor

merged and released as 1.9.0! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants