feat: Russian translation #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Success! Built with commit 4d6c19c |
jlengstorf
added
the
type: feature
orlowdev
reviewed
Aug 25, 2020
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
Co-authored-by: Sergei Orlov ||l <[email protected]>
|
@orlovedev Hi, Sergei! Thanks for your corrections! I agree with you that it should be a neutral translation. I tried to make it more human by writing things like "Вхожу", but for a wider audience, it should be the way you've suggested. Thanks! |
|
@noskovvkirill thank you. 🙂 It looks like there are a few conflicts now. I think the translations look great now, and the PR can be merged after they are resolved. |
|
@orlovedev yep, will resolve them as soon as I reach my laptop 😄 |
|
thank you both so much for putting the effort in here! |
|
|
||
| export const defaultLocale = "en"; | ||
| const translations = { en, fr, es, hu }; | ||
| const translations = { en, fr, es, hu, pt }; |
There was a problem hiding this comment.
Are Russian translations connected? I don't see reference here or in imports 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Russian translation :-)