Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Bump Netlify open-api version #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump Netlify open-api version #142

wants to merge 1 commit into from

Conversation

keiko713
Copy link
Contributor

We made several changes since we bumped the version last, so let's bump it.
Also use vX.Y.Z format.

@keiko713 keiko713 requested a review from bcomnes September 24, 2018 20:59
@keiko713
Copy link
Contributor Author

Ok sadly this is 🐇 🕳 .
The SiteSetup model shape in netlifyctl is like this (https://github.com/netlify/netlifyctl/blob/master/commands/init/init.go#L98-L101):

		setup := &models.SiteSetup{
			Site: *site,
			Repo: info,
		}

However, in open-api, we have changed this into somewhat different shape in netlify/open-api@a2fcf18#diff-7e7ec16647c95450034b610f374a5f10

This doesn't work. We need to think either 1) changing open-api (maybe to non flatten mode) or 2) changing netlifyctl to match with the current open-api.
Since there is no rush for releasing new version. I'll... just leave it for now.

@bcomnes
Copy link
Contributor

bcomnes commented Sep 24, 2018

I don't quote have enough context to know whats right, so I'll take your word for it when you decide.

Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to get a review in here: Approved when tests pass

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants