Reorg repo and README #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a few pointers from Irene
|
keiko713
reviewed
Sep 8, 2018
README.md
Outdated
|
|
||
| See [swagger-js](https://github.com/swagger-api/swagger-js) | ||
| See [CONTRIBUTING.md#go-client](CONTRIBUTING.md) for details on how this client is developed and generated. |
There was a problem hiding this comment.
do we need #go-client here (looks like it's not really pointing to anywhere specifically in contributing)?
keiko713
reviewed
Sep 8, 2018
README.md
Outdated
| @@ -1,47 +1,39 @@ | |||
| # Netlify open-api | |||
| # open-api | |||
| [](https://travis-ci.org/netlify/open-api) [](https://ci.appveyor.com/project/netlify/open-api/branch/master) | |||
There was a problem hiding this comment.
can we have a new line for each status? I think it still renders the same way
|
Left some comments but overall I like this change a lot! |
keiko713
reviewed
Sep 8, 2018
README.md
Outdated
| Swagger's JS client can dynamically create a client from a spec either from a URL or spec object. | ||
| - [Porcelain](https://godoc.org/github.com/netlify/open-api/go/porcelain): High level interactions and operations | ||
| - [Plumbing](https://godoc.org/github.com/netlify/open-api/go/plumbing): Low level client operations | ||
| - [Models](https://godoc.org/github.com/netlify/open-api/go/porcelain): Models generated by [go-swagger]() |
keiko713
reviewed
Sep 8, 2018
README.md
Outdated
|
|
||
| Swagger's JS client can dynamically create a client from a spec either from a URL or spec object. | ||
| - [Porcelain](https://godoc.org/github.com/netlify/open-api/go/porcelain): High level interactions and operations | ||
| - [Plumbing](https://godoc.org/github.com/netlify/open-api/go/plumbing): Low level client operations |
There was a problem hiding this comment.
maybe add "generated by go-swagger" here as well?
|
Thanks for the review @keiko713 ! I'll incorporate these changes. |
|
Okiedoke, this should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some ideas I had to reorganize this repo.