Skip to content

Save sha without original sha when to save in Hashed #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

keiko713
Copy link
Contributor

open-api will talk to api when to make a new deploy, which is the list of files and shas:

{ "index.html": "file_sha", "foo.jpg": "pointer_file_sha:original_file_sha", "bar.html": "file_sha2"}

then, api response the following as required (need to upload these shas to api):

["file_sha", "pointer_file_sha"]

so that open-api knows that it needs to upload files that have these shas (index.html and foo.jpg).

Previously, open-api wasn't able to upload "foo.jpg" because it didn't recognize "pointer_file_sha" is about "foo.jpg". This PR fixes it.

Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe have David or Bryce take a peek at this though to see if there is a better way to do this. It feels like we are hiding two different types in a single type, but I'm a typed language noob.

@bcomnes bcomnes merged commit 21a7d9c into master Sep 14, 2018
@bcomnes bcomnes deleted the not-save-in-hashed branch September 14, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants