Add createSiteBuild endpoint #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
reviewed
Jan 7, 2019
There was a problem hiding this comment.
LGTM
@bcomnes , @stefanjudis I think we need to generate the code to add this new route, don't we?
|
@calavera hmm, generate the code? I'm not sure I understand. :) |
|
nevermind, if you use the JS version you don't need to generate anything, I'll take care of the Go version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently building a netlify menubar client and use the netlify JS SDK. I found out that the swagger api definitions are missing the endpoint definition for a POST to
sites/$sitesId/buildswhich is used by the netlify Admin UI to manually trigger builds (which is functionality I'd like to provide in the Netlify menubar app).I talked to Dennis from support and he told me that the Netlify Admin UI is the source of truth. This PR adds documentation for the endpoint so that it'll be reflected in the JS Sdk and potentially Go SDK. :)