Change embedded DefaultSyncFileLimit to 500 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are also setting this as a default on BitBalloon, but in case anyone uses this elsewhere, they will get the correct default.
bcomnes
commented
Mar 7, 2019
| n.syncFileLimit = limit | ||
| if limit > 0 { | ||
| n.syncFileLimit = limit | ||
| } |
There was a problem hiding this comment.
This way, 0 value will take the default value given the way the buildbot initializes this client: https://github.com/netlify/buildbot/blob/5a312d8ce9ade738407c76651271f2b27353a6c9/api/api.go#L71-L72
rybit
approved these changes
Mar 7, 2019
bcomnes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are also setting this as a default on BitBalloon, but in case anyone uses this elsewhere, they will get the correct default.