Skip to content

Fix text error bug #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Fix text error bug #156

merged 2 commits into from
Apr 19, 2019

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Mar 8, 2019

This updates dependencies and adds an error response test. Down the road it can be adapted to cover the no consumer error, which is caused by a non-json response.

@bcomnes bcomnes added the wip label Mar 8, 2019
@netlify
Copy link

netlify bot commented Apr 19, 2019

Deploy preview for open-api ready!

Built with commit 03ec071

https://deploy-preview-156--open-api.netlify.com

@bcomnes bcomnes force-pushed the fix-text-error-bug branch from c6d8180 to 908eb03 Compare April 19, 2019 01:25
@bcomnes bcomnes force-pushed the fix-text-error-bug branch from cffff2c to 7d03426 Compare April 19, 2019 22:09
@bcomnes bcomnes removed the wip label Apr 19, 2019
@bcomnes bcomnes marked this pull request as ready for review April 19, 2019 22:16
}
return n.waitForState(ctx, d, timeout, "ready")
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code

@bcomnes bcomnes requested a review from keiko713 April 19, 2019 22:42
Copy link
Contributor

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have small comment but you can also ignore it 🙆

@bcomnes bcomnes merged commit 0f22659 into master Apr 19, 2019
@bcomnes bcomnes deleted the fix-text-error-bug branch April 19, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants