Skip to content

Fix YAML syntax error #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix YAML syntax error #193

merged 1 commit into from
Sep 17, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Sep 10, 2019

The current splitTests definition is parsed as:

{ 
  type: 'array', 
  items: null, 
  '$ref': '#/definitions/splitTest' 
}

Instead of:

{ 
  type: 'array', 
  items: {
    '$ref': '#/definitions/splitTest' 
  } 
}

@netlify
Copy link

netlify bot commented Sep 10, 2019 •
edited
Loading

Deploy preview for open-api ready!

Built with commit 3c3e3c5

https://deploy-preview-193--open-api.netlify.com

@ehmicky ehmicky assigned DavidWells and unassigned DavidWells Sep 16, 2019
@ehmicky ehmicky requested a review from DavidWells September 16, 2019 12:01
@DavidWells
Copy link
Contributor

Good eye!

@DavidWells DavidWells merged commit 167430a into master Sep 17, 2019
@DavidWells DavidWells deleted the bug/fix-openapi-syntax-error branch September 17, 2019 19:02
@ehmicky
Copy link
Contributor Author

ehmicky commented Sep 17, 2019

I actually caught it thanks to automated OpenAPI validation added by #194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidWells DavidWells DavidWells approved these changes

@futuregerald futuregerald Awaiting requested review from futuregerald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @DavidWells