Add unit tests #196
Merged
Add unit tests #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit aee9287 |
ehmicky
force-pushed
the
test/add-tests
branch
2 times, most recently
from
8c15861 to
b0caafe
Compare
DavidWells
approved these changes
Sep 17, 2019
ehmicky
force-pushed
the
test/add-tests
branch
from
b0caafe to
b7a7618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests.
The tests are meant to be low maintenance thanks to snapshots testing. They only check the shape of the exported/JSON OpenAPI definition and make sure it has not changed. When it does change (i.e. new definitions added to
swagger.yml),ava -ucan be run to update the snapshots.Those tests will ensure we are not introducing issues in the build/export setup.