Document deploy cancel #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit aa9051d |
ehmicky
reviewed
Feb 25, 2020
There was a problem hiding this comment.
The OpenAPI definition changes look good! Thank you so much for the speed on this!
There are some new files (swagger_flat.json and swagger_go.json). It looks like those are added by the generate.go file. I am not too familiar with the Go setup, but based on the CI tests, I think there might be an issue there.
ehmicky
approved these changes
Feb 25, 2020
kitop
reviewed
Mar 11, 2020
| @@ -628,6 +628,26 @@ paths: | |||
| $ref: '#/definitions/deploy' | |||
| default: | |||
| $ref: '#/responses/error' | |||
| /sites/{site_id}/deploys/{deploy_id}/cancel: | |||
There was a problem hiding this comment.
Late to the party, but URL for this is /deploys/{deploy_id}/cancel. with /sites/{site_id} will give a 404 :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the endpoint to cancel an in-progress build/depoy.