Warn if function conditions are not met #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit 337aa07 |
keiko713
reviewed
Apr 14, 2020
| file, err := newFunctionFile(filePath, i, goRuntime, observer) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| functions.Add(file.Name, file) | ||
| default: |
There was a problem hiding this comment.
I'm curious if there is a case that function directory could have some files that are not zip nor js nor go legitimately
There was a problem hiding this comment.
i think this walks the temporary dir from zisi, therefore only files that zisi picked up should be there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I recently discovered that we do not deploy go functions with invalid permissions set.
This made me want to introduce a warning for it.
DeployWarneris an interface that consumers of this library can choose to implement on top ofDeployObserver. Therefore this is not breaking.Test plan
I did not choose to implement a test because this is only a log output.
Cute animal