Skip to content

Upgrade go-swagger to 0.23.0 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2020
Merged

Upgrade go-swagger to 0.23.0 #234

merged 1 commit into from
May 11, 2020

Conversation

vbrown608
Copy link
Contributor

Code generation is failing in Go 1.14, this upgrades go-swagger to fix that.

Changes below are mostly whitespace and rearranging import lines. There's one more I found noteworthy, commented below.

Fixes #233

@vbrown608 vbrown608 requested a review from a team as a code owner May 11, 2020 19:33
@netlify
Copy link

netlify bot commented May 11, 2020

Deploy preview for open-api ready!

Built with commit ed1fac1

https://deploy-preview-234--open-api.netlify.app

@vbrown608 vbrown608 added the type: chore work needed to keep the product and development running smoothly label May 11, 2020
)

// New creates a new operations API client.
func New(transport runtime.ClientTransport, formats strfmt.Registry) *Client {
func New(transport runtime.ClientTransport, formats strfmt.Registry) ClientService {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client is now implemented as an interface so it can be mocked in tests. See go-swagger/go-swagger#1138

Copy link
Contributor

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🎉

@vbrown608 vbrown608 merged commit 13c0c58 into master May 11, 2020
@vbrown608 vbrown608 deleted the upgrade-go-swagger-0.23 branch May 11, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code generation fails with Go 1.14
2 participants