Use service as a returned object for showService #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiko713
added
the
type: chore
|
Deploy preview for open-api ready! Built with commit 11afbdb |
kitop
approved these changes
Oct 8, 2020
|
Do you want me to merge and cut a release for this? |
|
@erezrokah thanks for checking! this is small enough and not being a blocker of anything, so this can go with some other release in my opinion (or, of course, we could still release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a small bug, noticed while reviewing netlify/cli#1344
Looks like this one is not currently used for any Netlify owned client (js-client, go client, CLI, etc.).
It's always nice to fix the bug whenever we notice!