Skip to content

Indicate error message is not-nullable to fix error messages #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

Indicate error message is not-nullable to fix error messages #31

merged 1 commit into from
Oct 30, 2017

Conversation

brycekahle
Copy link
Contributor

@brycekahle brycekahle commented Oct 30, 2017 •
edited
Loading

@brycekahle brycekahle requested a review from rybit October 30, 2017 20:53
rybit
rybit approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@rybit rybit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reading every diff, but that change seems safe

@brycekahle brycekahle merged commit 1bc0d14 into master Oct 30, 2017
@brycekahle brycekahle deleted the fix-error-messages branch October 30, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rybit rybit rybit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycekahle @rybit