fix: race condition when waiting for sharedError #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4xposed
force-pushed
the
fix_race_condition_on_uploadFiles
branch
from
c58df5a to
40bd8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue with some files failing to upload we encountered that when calling:
defer wg.Wait()having a
returnstatement, the return value would be assigned first, and then we would wait for the wait group, you can explore this issue on this playground link: https://go.dev/play/p/nuOytLQbkQyWhy it did not affect every single deploy?
Some Deploys returned some errors because they were blocked here: https://github.com/netlify/open-api/blob/master/go/porcelain/deploy.go#L433-L435 due to having too many files and waiting for the initialized semaphore, giving it a chance for
sharedErrto have a value assigned before it be assigned to thereturnstatement.