Complete site's build settings. #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build settings is basically a repository into object underneath. This changes the definition to reuse the RepoInfo struct. `repo_branch` is used a read/write attribute to set the production branch for a site. Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
complete_build_settings
branch
from
6a13d32 to
f6fb587
Compare
|
Thanks! That's no problem and I noticed that there was some weird naming thing going on there but had no idea which way was the right way. I'll update this to work no problem. Thank you. |
|
Hey @calavera I noticed the frontend sends |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build settings is basically a repository into object underneath.
This changes the definition to reuse the RepoInfo struct.
repo_branchis used a read/write attribute to set the production branch for a site.
@mitchellh
repo_typeis a deprecated field and we don't use it for anything. This change should address the rest of attributes.I renamed
branchtorepo_branchbecause it's only one property that you can use it for read and write.Fixes #57.
Signed-off-by: David Calavera [email protected]