Replace backslashes in file path names. #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
force-pushed
the
fix_windows_path
branch
from
8907e73 to
abf5aa0
Compare
rybit
reviewed
May 23, 2018
go/porcelain/deploy.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| rel := cleanFileName(osRel) |
There was a problem hiding this comment.
you could use filepath.Clean https://golang.org/pkg/path/filepath/#Clean
There was a problem hiding this comment.
@rybit That will not do what we want. We want to replace filepath.Separator with / always.
There was a problem hiding this comment.
I'm going to change the function name, it's misleading.
There was a problem hiding this comment.
There was a problem hiding this comment.
No, because on windows, separator = \
There was a problem hiding this comment.
That means that for any windows machine, this will force / not \? If you guys say that is right then ok! You've got more context than me.
There was a problem hiding this comment.
This is precisely the bug we are trying to fix! netlify/netlifyctl#109
brycekahle
approved these changes
May 23, 2018
Fixes issues not deploying files under the right paths using Windows. Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
fix_windows_path
branch
from
abf5aa0 to
a524e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues not deploying files under the right paths using Windows.
Fixes #86
Signed-off-by: David Calavera [email protected]