feat: add @netlify/vite-plugin-react-router to support React Router 7 #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
2 times, most recently
from
176717d to
95339a7
Compare
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
from
95339a7 to
5a4d475
Compare
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
from
5a4d475 to
c0203ab
Compare
serhalp
changed the title
serhalp
commented
Dec 10, 2024
| @@ -67,14 +67,12 @@ | |||
| "@remix-run/react": "^2.12.0", | |||
| "@types/react": "^18.0.27", | |||
| "@types/react-dom": "^18.0.10", | |||
| "lambda-tester": "^4.0.1", | |||
serhalp
commented
Dec 10, 2024
| }, | ||
| "peerDependencies": { | ||
| "@netlify/functions": "^2.8.1", |
There was a problem hiding this comment.
I don't think this was ever relevant, or at least it isn't currently
serhalp
commented
Dec 10, 2024
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "tsup": "^8.0.2", | ||
| "vite": "^5.1.3" | ||
| "vite": "^5.4.11" |
There was a problem hiding this comment.
I had to upgrade this to resolve some type issues caused by having multiple versions of vite in the workspace.
serhalp
commented
Dec 10, 2024
serhalp
commented
Dec 10, 2024
serhalp
commented
Dec 10, 2024
serhalp
commented
Dec 10, 2024
| @@ -0,0 +1,247 @@ | |||
| import { expect, test } from './support/fixtures' | |||
|
|
|||
| test.describe('React Router user journeys', () => { | |||
There was a problem hiding this comment.
These are almost identical to the Remix e2e tests. We only changed a few strings like "Welcome to Remix", etc.
mrstork
reviewed
Dec 11, 2024
mrstork
reviewed
Dec 11, 2024
mrstork
reviewed
Dec 11, 2024
Merged
serhalp
added a commit
that referenced
this pull request
Dec 13, 2024
Added in #472 but didn't realize there was a config file to update!
serhalp
added a commit
that referenced
this pull request
Dec 13, 2024
* ci(release-please): add new package to config Added in #472 but didn't realize there was a config file to update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remix has converged with React Router and the "next version" of Remix was released as React Router 7.
This PR adds a new package to support React Router 7:
@netlify/vite-plugin-react-router. The naming convention is different as this is purely a Vite plugin (previous "adapters" also supported the Remix Classic Compiler), so we were able to follow the documented naming convention.Future work
@netlify/remix-adapter. We should probably refactor to extract the shared logic.Related Tickets & Documents
FRB-1511
Supersedes #471
See also netlify/remix-template#157
QA Instructions, Screenshots, Recordings
This PR adds extensive e2e tests.
I also added a new React Router Netlify template here: netlify/react-router-template#1. It uses this new plugin, and you can see the successful deploy preview there.