Skip to content

Avoid redundant frontend builds #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Avoid redundant frontend builds #707

merged 1 commit into from
Feb 6, 2025

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 31, 2025

The goal is to avoid redundant frontend builds for each architecture, since the frontend artifacts are just plain text files / noarch.

For now it's only for upstream builds, but the goal would be to have the same with konflux

The goal is to avoid redundant frontend builds for each architecture,
since the frontend artifacts are just plain text files / noarch.

For now it's only for upstream builds, but the goal would be to have the
same with konflux
Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 31, 2025

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress f8d4713 link true /test plugin-cypress
ci/prow/qe-e2e-console-tests f8d4713 link false /test qe-e2e-console-tests
ci/prow/images f8d4713 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good 👌

Just some thoughts here:

  • We may want to merge with Dockerfile.cypress and Dockerfile.downstream too
  • We could also have a Dockerfile.back for consistency

@jotak
Copy link
Member Author

jotak commented Feb 4, 2025

@jpinsonneau I agree there's more to do

  • downstream => we need to update the konflux pipeline accordingly
  • cypress => we need to update prow... anyway prow needs an update in any case I think

@jotak
Copy link
Member Author

jotak commented Feb 6, 2025

Talked with Mehul, I'll merge it as it is and then fix what's broken in prow

@jotak jotak merged commit fa5defa into netobserv:main Feb 6, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants