Skip to content

NETOBSERV-1942 PoC config / status views + NETOBSERV-1945 resource calculator #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 12, 2025

Description

compressed.webm

This is a Poc. Code can be divided into multiple PRs if you feel it's needed:

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 51.82482% with 66 lines in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (8c01669) to head (b146c12).

Files with missing lines Patch % Lines
web/moduleMapper/dummy.tsx 23.91% 35 Missing ⚠️
web/src/utils/yaml.ts 9.09% 10 Missing ⚠️
web/src/components/forms/dynamic-form/utils.ts 73.07% 7 Missing ⚠️
web/src/components/forms/config/templates.ts 57.14% 6 Missing ⚠️
pkg/server/routes.go 82.60% 2 Missing and 2 partials ⚠️
web/src/utils/k8s-models-hook.ts 33.33% 2 Missing ⚠️
pkg/config/config.go 87.50% 1 Missing ⚠️
web/src/components/netflow-traffic-tab.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   55.51%   55.37%   -0.14%     
==========================================
  Files         197      200       +3     
  Lines       10522    10633     +111     
  Branches     1226     1247      +21     
==========================================
+ Hits         5841     5888      +47     
- Misses       4312     4374      +62     
- Partials      369      371       +2     
Flag Coverage Δ
uitests 57.72% <42.45%> (-0.24%) ⬇️
unittests 50.06% <83.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...b/src/components/drawer/netflow-traffic-drawer.tsx 46.07% <100.00%> (ø)
web/src/components/messages/error.tsx 21.42% <100.00%> (ø)
web/src/utils/url.ts 77.41% <100.00%> (+0.37%) ⬆️
pkg/config/config.go 42.50% <87.50%> (+1.85%) ⬆️
web/src/components/netflow-traffic-tab.tsx 62.50% <50.00%> (ø)
web/src/utils/k8s-models-hook.ts 91.11% <33.33%> (-4.13%) ⬇️
pkg/server/routes.go 60.00% <82.60%> (-3.08%) ⬇️
web/src/components/forms/config/templates.ts 57.14% <57.14%> (ø)
web/src/components/forms/dynamic-form/utils.ts 73.07% <73.07%> (ø)
web/src/utils/yaml.ts 9.09% <9.09%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpinsonneau jpinsonneau force-pushed the 1942 branch 6 times, most recently from 5d6fd6f to 12ec282 Compare March 20, 2025 16:29
@jpinsonneau jpinsonneau force-pushed the 1942 branch 2 times, most recently from 7c1c429 to 28d93a4 Compare April 1, 2025 09:38
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 2, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 2, 2025
@jpinsonneau jpinsonneau force-pushed the 1942 branch 3 times, most recently from f69f0df to 6ec375c Compare April 8, 2025 12:34
@netobserv netobserv deleted a comment from github-actions bot Apr 14, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 14, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 15, 2025
@netobserv netobserv deleted a comment from github-actions bot Apr 15, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 15, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 15, 2025
@jpinsonneau jpinsonneau marked this pull request as ready for review April 17, 2025 08:25
@netobserv netobserv deleted a comment from github-actions bot Apr 17, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 17, 2025
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:a4950b6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a4950b6 make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 28, 2025
@jpinsonneau jpinsonneau changed the title NETOBSERV-1942 PoC config / status views NETOBSERV-1942 PoC config / status views + NETOBSERV-1945 resource calculator Apr 28, 2025
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 30, 2025
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:a4950b6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a4950b6 make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 30, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 30, 2025
@jpinsonneau
Copy link
Contributor Author

rebased without changes

Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:c54b5b6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=c54b5b6 make set-plugin-image

Copy link

openshift-ci bot commented Apr 30, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 078408b link true /test plugin-cypress
ci/prow/qe-e2e-console-tests 078408b link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants