Skip to content

Add support for trailling comma for method paramerts #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astronom opened this issue Mar 21, 2022 · 4 comments
Closed

Add support for trailling comma for method paramerts #106

astronom opened this issue Mar 21, 2022 · 4 comments

Comments

@astronom
Copy link
Contributor

Since the last update trailing comma supports for constructor property promotion. Also support for arrays. But there is no support for method and function parameters.

See https://github.com/nette/php-generator/blob/master/src/PhpGenerator/Printer.php#L322 Var special is determined dynamically

Suggest to add some parameter to Printer and support trailing comma whether needed.

@dg
Copy link
Member

dg commented Apr 2, 2022

Oh, that's a bug in the code, it was supposed to print trailing comma every time.

@astronom
Copy link
Contributor Author

astronom commented Apr 5, 2022

I instal the version with fix and it is working!
But in dev-master now is trailing whitespace in comment...
When are youg going to release?

@dg
Copy link
Member

dg commented Apr 5, 2022

I tried to fix it, can you test it?

@astronom
Copy link
Contributor Author

astronom commented Apr 6, 2022

I suppose this will fix trailing whitespace in multiline comments #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants