Skip to content

Ensure that object class contains path from root namespace #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PhpGenerator/Factory.php
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ public function fromPropertyReflection(\ReflectionProperty $from): Property

public function fromObject(object $obj): Literal
{
return new Literal('new ' . $obj::class . '(/* unknown */)');
return new Literal('new \\' . $obj::class . '(/* unknown */)');
}


Expand Down
1 change: 1 addition & 0 deletions tests/PhpGenerator/ClassType.from.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ $res[] = ClassType::from(Abc\Class7::class);
$res[] = ClassType::from(Abc\Class8::class);
$res[] = ClassType::from(Abc\Class9::class);
$res[] = ClassType::from(Abc\Class10::class);
$res[] = ClassType::from(Abc\Class11::class);

sameFile(__DIR__ . '/expected/ClassType.from.expect', implode("\n", $res));
4 changes: 2 additions & 2 deletions tests/PhpGenerator/expected/ClassType.from.81.expect
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#[Attr(new Abc\Attr(/* unknown */))]
#[Attr(new \Abc\Attr(/* unknown */))]
class Class11
{
final public const FOO = 10;
Expand All @@ -12,7 +12,7 @@ class Class11
}


public function bar($c = new stdClass(/* unknown */))
public function bar($c = new \stdClass(/* unknown */))
{
}
}
12 changes: 12 additions & 0 deletions tests/PhpGenerator/expected/ClassType.from.expect
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,15 @@ class Class10
{
}
}

class Class11
{
public string|int $prop;


public function test(
Class2 $param = new \Abc\Class2(/* unknown */),
Class3 $param2 = new \Abc\Class3(/* unknown */),
): string|int {
}
}
10 changes: 10 additions & 0 deletions tests/PhpGenerator/expected/Extractor.classes.expect
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,13 @@ class Class10
{
}
}

class Class11
{
public string|int $prop;


function test(Class2 $param = new Class2(), Class3 $param2 = new Class3()): string|int
{
}
}
9 changes: 9 additions & 0 deletions tests/PhpGenerator/fixtures/classes.php
Original file line number Diff line number Diff line change
Expand Up @@ -174,3 +174,12 @@ function test(mixed $param): string|int
{
}
}

class Class11
{
public string|int $prop;

function test(Class2 $param = new Class2(), \Abc\Class3 $param2 = new \Abc\Class3()): string|int
{
}
}