Skip to content

Model Compression: Delete offload #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Model Compression: Delete offload #319

wants to merge 1 commit into from

Conversation

kylesayrs
Copy link
Contributor

Purpose

  • Save CPU memory by properly deleting offload parameters

Changes

  • Use delete_offload_parameter rather than delattr when deleting unused parameters during compression
  • Determine the module's offload_device for use when registering new offload parameters

Testing

  • Model compression and decompression tests pass, and offload state dict does not include unnecessary keys after changes

@kylesayrs
fix deleting offload
3e3d40b 
Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
brian-dellabetta approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylesayrs @brian-dellabetta