Skip to content

Make MSE the default #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make MSE the default #324

wants to merge 2 commits into from

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented May 22, 2025

No description provided.

@dsikka
Copy link
Collaborator Author

dsikka commented May 22, 2025

Please dont merge until @shanjiaz resolves timing issues

Copy link
Contributor

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to understand something

Copy link
Contributor

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This will likely cause LC tests to fail, as the fix only fixes one of the two test functions that were failing

  2. We should probably add a test in LC that tests the MSE observer just as we did with the min max observer already done

  3. The failure illustrates the issue that the MSE observer raises an error when it is used to quantize integer values. While tests may pass, there may be other circumstances where we want to quantize values which are integers. Adding integer quantization support is relatively quick and would be a nice follow up, but doesn't have to be done now

@shanjiaz
Copy link
Contributor

  1. This will likely cause LC tests to fail, as the fix only fixes one of the two test functions that were failing
  2. We should probably add a test in LC that tests the MSE observer just as we did with the min max observer already done
  3. The failure illustrates the issue that the MSE observer raises an error when it is used to quantize integer values. While tests may pass, there may be other circumstances where we want to quantize values which are integers. Adding integer quantization support is relatively quick and would be a nice follow up, but doesn't have to be done now

Good catch! Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants