-
Notifications
You must be signed in to change notification settings - Fork 183
[Text Generation] Terminate the inference when kv cache is full #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dbogunowicz
merged 6 commits into
main
from
feature/damian/terminate_inference_when_kv_cache_full
Dec 6, 2023
Merged
[Text Generation] Terminate the inference when kv cache is full #1446
dbogunowicz
merged 6 commits into
main
from
feature/damian/terminate_inference_when_kv_cache_full
Dec 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4be8a07
to
c247618
Compare
Satrat
previously approved these changes
Dec 1, 2023
dbogunowicz
commented
Dec 1, 2023
Satrat
previously approved these changes
Dec 1, 2023
bfineran
previously approved these changes
Dec 4, 2023
bfineran
approved these changes
Dec 6, 2023
Satrat
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Description
Once the KV cache is full, instead of continuing the inference by removing the old cache entries to make place for the new ones, we now terminate the inference with the finish reason "capacity"
Manual Testing
Before:
displaying
out.generations[0].text
andout.generations[0].finished_reason
:Now: