Kwest/java layer poc #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrickard
approved these changes
Apr 22, 2021
katiewest820
force-pushed
the
kwest/java-layer-poc
branch
from
c475224 to
1803ccb
Compare
MattWhelan
approved these changes
Apr 28, 2021
java/build.gradle
Outdated
|
|
||
| dependencies { | ||
| implementation("io.opentracing:opentracing-util:0.33.0") | ||
| implementation("com.newrelic.opentracing:newrelic-java-lambda:2.2.0") |
There was a problem hiding this comment.
This should be 2.2.1, which resolves several serious concurrency issues.
java/publish-layers.sh
Outdated
| JAVA_DIST=distributions/NewRelicJavaLayer.zip | ||
|
|
||
| EXTENSION_DIST_DIR=extensions | ||
| EXTENSION_DIST_URL=https://github.com/newrelic/newrelic-lambda-extension/releases/download/v1.2.1.2/newrelic-lambda-extension.zip |
There was a problem hiding this comment.
this should be version 1.2.4
kolanos
reviewed
Apr 28, 2021
|
|
||
| echo "Publishing java 8 layer to ${region}" | ||
| java_version=$(aws lambda publish-layer-version \ | ||
| --layer-name NewRelicJava8 \ |
There was a problem hiding this comment.
Should we include the AL2 part? There is a java8 runtime as well (unsupported by extensions), suspect this may be confusing.
@kolanos I took a shot at the Circle CI stuff. Let me know if I missed anything or if anything needs changing. |
kolanos
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java layer for
RequestHandlerandRequestStreamHandlerimplementationshttps://newrelic.atlassian.net/browse/LAMBDA-1189