-
Notifications
You must be signed in to change notification settings - Fork 60
Fix The CustomResourceDefinition Installation Error #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
$SUDO $KUBECTL create -f https://raw.githubusercontent.com/pixie-io/pixie/main/k8s/operator/helm/crds/olm_crd.yaml 2>/dev/null | ||
$SUDO $KUBECTL create -f https://raw.githubusercontent.com/pixie-io/pixie/main/k8s/operator/crd/base/px.dev_viziers.yaml 2>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command still returns an exit code of 1. can you double check that the install script ignores the exit status and continues to run?
additionally you might want to consider using a released version here such as https://raw.githubusercontent.com/pixie-io/pixie/release/operator/v0.1.0/k8s/operator/helm/crds/olm_crd.yaml
instead of using main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only keeping stderr with 2>&1 >/dev/null; if the error includes any other than AlreadyExist, exit the script
We need to make sure that the versions are updated here when the charts are too. Can you please add an item to the release checklist to make sure someone updates this script when updating the version in the nri-bundle? |
Created this PR, Is there a place specific for the release checklist? |
Description
Customers recently got the following errors after March 24th.
Code changes
We think the issue is same as this issue and follow the fix to make this PR.
Tests
Test 2>&1 >/dev/null only keeping stderr in ERROR