Skip to content

feat(providers): added SoundCloud provider #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat(providers): added SoundCloud provider #3278

wants to merge 4 commits into from

Conversation

stardvst
Copy link

@stardvst stardvst commented Nov 25, 2021

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@github-actions github-actions bot added core Refers to `@auth/core` docs Relates to documentation providers test Related to testing TypeScript Issues relating to TypeScript labels Nov 25, 2021
return {
id: profile.id,
name: profile.full_name,
username: profile.username,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoundCloud doesn't provide email, so I added username. Please review this.

@stardvst stardvst changed the title fix #3360 add SoundCloud provider feat(providers): added SoundCloud provider Nov 25, 2021
@balazsorban44
Copy link
Member

balazsorban44 commented Nov 25, 2021

We are releasing v4 next week, and this PR targets v3, which isn't being worked on anymore. I kindly ask you to wait until next week to reopen this, but you can have a look at the new required syntax here:

https://github.com/nextauthjs/next-auth/tree/beta/src/providers

https://next-auth.js.org/configuration/providers/oauth#options

@stardvst
Copy link
Author

@balazsorban44 sure, thanks for the info. will rework for v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` docs Relates to documentation providers test Related to testing TypeScript Issues relating to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants