Skip to content

Refactor HTTP auth modules #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Refactor HTTP auth modules #141

merged 9 commits into from
Jun 15, 2021

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Jun 10, 2021

Proposed changes

Refactor the auth HTTP config template into its own separate file, as well as add support for auth_jwt directives. All variables have changed (check defaults/main/template.yml for examples):
* All the various auth variables now live within their respective auth dictionaries.
* auth configs are now supported within the http, server, and location contexts.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jun 10, 2021
@alessfg alessfg added breaking change Implies a breaking change enhancement Enhance an existing feature labels Jun 10, 2021
@alessfg alessfg added this to the 0.4.0 milestone Jun 10, 2021
@alessfg alessfg removed the enhancement Enhance an existing feature label Jun 10, 2021
@alessfg alessfg merged commit bc7c117 into main Jun 15, 2021
@alessfg alessfg deleted the auth-templates branch June 15, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant