Skip to content

Refactor HTTP health check module #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

Refactor HTTP health check module #152

merged 1 commit into from
Jul 5, 2021

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Jul 5, 2021 •
edited
Loading

Proposed changes

Refactor server.health_check_plus into its own dictionary that now includes all the health_check module directives.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jul 5, 2021
@alessfg alessfg added the breaking change Implies a breaking change label Jul 5, 2021
@alessfg alessfg added this to the 0.4.0 milestone Jul 5, 2021
@alessfg alessfg merged commit bb6f151 into main Jul 5, 2021
@alessfg alessfg deleted the refactor-health-checks branch July 5, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
breaking change Implies a breaking change
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg