Skip to content

Use TLS to fetch nginx sources, signatures and public keys #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Oct 15, 2017

No description provided.

@thresheek
Copy link
Member

We're checking sources against a known signature, so TLS is absolutely unneeded here.

Also, at least keyserver.ubuntu.com does not speak hkps on port 80 - did you actually check what you've committed?

@thresheek thresheek closed this Oct 16, 2017
@J0WI
Copy link
Contributor Author

J0WI commented Oct 16, 2017

There was already discussion here about the benefits of TLS. In the case of http I see no drawback.
Meanwhile, using https has become a common practice for official images:

docker-library/golang#12
docker-library/drupal#55
docker-library/ruby#87
docker-library/redmine#34
docker-library/php#293
docker-library/busybox@8b0d966
docker-library/memcached@0991958

I tested the build locally and it works for me. If you prefer, I can split the hkps change into another PR. I never seen Dockerfiles using multiple key servers, but I also didn't found a guideline about this topic.

@thresheek
Copy link
Member

It works because it uses the first gpg keyserver to fetch the keys. It does indeed seems that https is becoming prevalent in official images, so fix that PR and re-send.

@J0WI
Copy link
Contributor Author

J0WI commented Oct 17, 2017

@thresheek I've created #208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants