generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 59
fix: N1C. Help users look for "out of sync" Instances in a CSG #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mjang
wants to merge
5
commits into
main
Choose a base branch
from
fix-n1c-config-sync-group-instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -100,6 +100,9 @@ Now that you created a Config Sync Group, you can add instances to that group. A | |||||
|
||||||
Any instance that joins the group afterwards inherits that configuration. | ||||||
|
||||||
{{< note >}} If there are conflicts between an instance and the Config Sync Group, you'll see the following [Config Sync Group Status](#config-sync-group-status) message: **Out of Sync**. | ||||||
In that case, review and resolve discrepencies between the Instance and the rest of the Config Sync Group. {{< /note >}} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
### Add an existing instance to a Config Sync Group {#add-an-existing-instance-to-a-config-sync-group} | ||||||
|
||||||
You can add existing NGINX instances that are already registered with NGINX One to a Config Sync Group. | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an instance is out of sync, it wouldn't necessarily be because there is a conflict between the instance and the CSG, it's usually due to some errors in the NGINX configuration that is either not caught when users created the CSG, or something has gone wrong on the data plane instance.
Here is roughly what I think that could be helpful to include in this part of the doc:
Feel free to make any changes as you see fit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like far too much information to throw into a note: might feel better once it's had an edit pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sylwang wdyt?